Open
Conversation
Contributor
|
可以讨论下必要性,我个人觉得这个没多大必要:
|
Author
个人建议哈:
综上,还是建议能更多的考虑 |
Author
func splitKey(key string, val interface{}) (field string, operator string, err error) {
key = strings.Trim(key, " ")
if "" == key {
err = errSplitEmptyKey
return
}
idx := strings.IndexByte(key, ' ')
if idx == -1 {
field = key
operator = "="
if isFieldContainOp(field) {
field, operator = splitKeyNoSpace(field)
}
if reflect.ValueOf(val).Kind() == reflect.Slice {
operator = "in"
}
} else {
field = key[:idx]
operator = strings.Trim(key[idx+1:], " ")
operator = removeInnerSpace(operator)
}
return
}
func isFieldContainOp(field string) (contains bool) {
if field == "" {
return
}
ecof := field[len(field)-1:]
contains = ecof == opEq || ecof == opLt || ecof == opGt
return
}
` |
Author
|
可以尝试 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
map with key
foo>instead offoo >gotfield="foo>"operator="=", then where condition isfoo>=.got
when no space in
key, not defaultfield=keyandoperator="=", but try to parsefileds linked with ops, such asfoo>,foo>=,foo<,foo<=,foo<>,foo!=,foo=